fix(diff): release graphs from memory as they are completed#988
Merged
Conversation
Because the `as_completed()` call was outside of the with scope, we were waiting for all futures to complete before processing any of them. Also we were storing futures (which contain the full output) in a dict. This meant we were holding the output of all graph generations in memory simultaneously. In Gecko, this will eat through your available RAM in no time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the
as_completed()call was outside of thewithscope, we were waiting for all futures to complete before processing any of them. Also we were storing futures (which contain the full output) in a dict.This meant we were holding the output of all graph generations in memory simultaneously. In Gecko, this will eat through your available RAM in no time.