Repository navigation
ci: run on Node.js 26 too, with 22 and 24 - #199
Merged
Merged
Conversation
engines already allows Node.js 26. The README and the 1.1.0 entry of the CHANGELOG say which versions the CI runs on.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI runs on Node.js 26 as well as 22 and 24: the matrix of
.github/workflows/ci.ymlis now[22, 24, 26].engines(>=22.22.1) already allows Node.js 26, sopackage.jsondoes not change..nvmrcstill has 24.Checks
On Node.js 26.12.1, with the commands the workflow runs:
yarn format:check,yarn lint,yarn typecheck,yarn buildpass, andyarn testgives 275 passing and 1 todo, on React 19 and on React 18. The Node.js 26 job of this PR is the check on the runner.Notes for review
release/1.1.0and their checks run again.mastergets the change with the release PR (Release v1.1.0 #196).