Increase test coverage, fix modified UTF-8/__hash__ bugs, containerize CI - #67
Merged
Conversation
Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
actions/setup-python can't install 2.7 or 3.4-3.7 on current runners, so each version's suite now runs inside the matching python:<version> image via run_tests_containers.sh (podman locally, Docker in CI). Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
The CI badge still pointed at the deleted build-24.04.yml and the wrong branch; the Maven requirement note still named the old tests.py file. Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
The new CI step runs mvn test for real instead of swallowing its exit code like test_v3.py does, and it exposed two pre-existing bugs: SerializationExample was a public class in a wrongly named file, and its CustomClass collided with the one already in OneTest.java (renamed to Issue60CustomClass). Also skip testSwingObject when there's no display (CI, containers) instead of failing on HeadlessException; its fixture is already committed. Signed-off-by: Thomas Calmant <thomas.calmant@gmail.com>
|
coverage: 92.232% (+13.3%) from 78.938% — tests-review into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan