Skip to content

Add missing German translations for 2017sm - #2473

Open
Que-tin wants to merge 1 commit into
tcgdex:masterfrom
Que-tin:de/2017sm
Open

Que-tin wants to merge 1 commit into
tcgdex:masterfrom
Que-tin:de/2017sm

Conversation

@Que-tin

@Que-tin Que-tin commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Add missing German translations for 2017sm

How and why?

I was playing around with the databse, when I noticed I can't find plenty of my
german cards due to lacking docs or because there was english text in the german
card docs.

So I build a tool locally (with AI) to check for german gaps and fill them up
with actual authentic card data. To make sure this data is accurate I'm using
PokéWiki (large german card database) + OCR on card screenshots + the
NSSpellChecker with the German dictionary to make sure no mistakes from the
wiki or the scan get into the files.

I will create plenty of PRs because the german documentation right now is far
from complete. If you have any question let me know. Where changes come from
etc. is fully logged on my device and I can tell you where which text comes
from.

@TCGdexBOT

Copy link
Copy Markdown
Member

🃏 12 Cards Changed

Details: 12 with errors

⚠️ Error processing 1.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/1.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 10.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/10.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 11.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/11.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 12.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/12.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 2.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/2.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 3.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/3.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 4.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/4.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 5.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/5.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 6.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/6.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 7.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/7.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 8.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/8.ts

Error: Failed to fetch card information in all available languages

⚠️ Error processing 9.ts

File: data/McDonald's%20Collection/McDonald's%20Collection%202017/9.ts

Error: Failed to fetch card information in all available languages

37 repair(s) across 12 card(s), 37 gap(s) found, 0 declined.

German strings are exact template values read from PokéWiki article source via
the MediaWiki API, not OCR. Only `de` entries are touched; every other byte of
each card file is unchanged.

Fields repaired: attack and ability names, attack and ability effect text,
evolveFrom, description, and Trainer effect text, wherever the stored German
was missing, identical to the English, or was itself English.

evolveFrom names a different Pokémon than the card, so it is not on the card's
own article; those come from an English-to-German name map joined out of
TCGdex's own bulk card lists on card id, and only where near-unanimous.

Generated by card-scraper. Per-change evidence, including the source article
URL for every string, is in each card's out/card.json beside its wiki.json
wikitext snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants