Repository navigation
Add missing German translations for dp5 - #2474
Merged
Merged
Conversation
Member
🃏 2 Cards ChangedDetails: 2 modified Glameow (dp5-65) (found using en)
File: [data/Diamond & Pearl/Majestic Dawn/65.ts](https://github.com/tcgdex/cards-database/blob/af57972e8f784c2507ab9e573c99bf02ae2e5e42/data/Diamond & Pearl/Majestic Dawn/65.ts) Helix Fossil (dp5-91) (found using en)
File: [data/Diamond & Pearl/Majestic Dawn/91.ts](https://github.com/tcgdex/cards-database/blob/af57972e8f784c2507ab9e573c99bf02ae2e5e42/data/Diamond & Pearl/Majestic Dawn/91.ts) |
10 repair(s) across 100 card(s), 25 gap(s) found, 11 declined. German strings are exact template values read from PokéWiki article source via the MediaWiki API, not OCR. Only `de` entries are touched; every other byte of each card file is unchanged. Fields repaired: attack and ability names, attack and ability effect text, evolveFrom, description, and Trainer effect text, wherever the stored German was missing, identical to the English, or was itself English. evolveFrom names a different Pokémon than the card, so it is not on the card's own article; those come from an English-to-German name map joined out of TCGdex's own bulk card lists on card id, and only where near-unanimous. Generated by card-scraper. Per-change evidence, including the source article URL for every string, is in each card's out/card.json beside its wiki.json wikitext snapshot.
thomas-bassett
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing German translations for dp5
How and why?
I was playing around with the databse, when I noticed I can't find plenty of my
german cards due to lacking docs or because there was english text in the german
card docs.
So I build a tool locally (with AI) to check for german gaps and fill them up
with actual authentic card data. To make sure this data is accurate I'm using
PokéWiki (large german card database) + OCR on card screenshots + the
NSSpellCheckerwith the German dictionary to make sure no mistakes from thewiki or the scan get into the files.
I will create plenty of PRs because the german documentation right now is far
from complete. If you have any question let me know. Where changes come from
etc. is fully logged on my device and I can tell you where which text comes
from.