Repository navigation
Add set-market-fee-recipient, and SET_MARKET_FEE_RECIPIENT to run it - #357
Merged
Merged
Conversation
A market with no fee recipient pays its owner, and every market the bootstrap creates is owned by the deployer. This points a market's fee elsewhere: ids from the registry, markets owned by another signer skipped, the value read back after the write. Market ids are required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DPGQ6yZrEK3E9QwXesRojq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A market with no fee recipient pays its marketplace fee to its owner, and every market
bootstrap-marketscreates is owned by the deployer. This adds a task to point a market's fee at another address, and adeploy-chain.shmode to run it.helpers/tasks/set-market-fee-recipient.ts: same shape asset-market-payment-default.--marketsis required; it never sweeps every market by default.scripts/deploy-chain.sh:SET_MARKET_FEE_RECIPIENT=truewithMARKET_FEE_RECIPIENT,MARKET_FEE_MARKETSandMARKET_FEE_DRY_RUN, placed afterSET_PAYMENT_DEFAULTand listed in the "nothing to do" help.The change applies to loans funded from now on; fees already paid are unaffected.
Testing
bash -n scripts/deploy-chain.shtsc --strictagainst ethers 6 and hardhat 2.🤖 Generated with Claude Code
https://claude.ai/code/session_01DPGQ6yZrEK3E9QwXesRojq
Generated by Claude Code