Repository navigation
Conversation
MatcherSignature does not emit an overload; the matcher (int) does not match the target (string), so only MOG002 is reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the comment in
Class_21_AcceptanceCriterias(ref/Tenekon.MethodOverloads.AcceptanceCriterias/Class_21.cs).Before:
// Diagnostics are expected for the cases above, but MatcherSignature now emits a receiver-only overload.After:
// No overloads expected: every case above only triggers a diagnostic (MatcherSignature: int vs. string → MOG002).Why
The second half of the old comment did not match the generator's behavior.
Class_21_Matcher.MatcherSignature(int m)does not match the targetClass_21_Matched.MatcherSignature(string m)underTypeOnlymatching, so no overload is emitted and MOG002 is reported instead. If an overload were emitted, the acceptance test would fail with "Extra", becauseClass_21_AcceptanceCriteriasis intentionally empty.Verified against the current generator, both in-memory (acceptance fixture) and via a real build of the acceptance project with the generator enabled: no
MatcherSignatureoverload is generated.Notes for reviewers
bbca90c;mainhas since moved (merge of fix(tests): disable MSBuild node reuse for spawned builds #2), but there is no overlap with this file.🤖 Generated with Claude Code