Skip to content

fix(ci): exclude attestations when combining image manifests - #249

Open
ilopezluna wants to merge 1 commit into
testcontainers:mainfrom
ilopezluna:codex/fix-manifest-attestations
Open

ilopezluna wants to merge 1 commit into
testcontainers:mainfrom
ilopezluna:codex/fix-manifest-attestations

Conversation

@ilopezluna

@ilopezluna ilopezluna commented Nov 14, 2026 •

Copy link
Copy Markdown

Fix multi-platform image publication failing with must have an OS and Architecture by selecting only runnable Linux images before combining them with Windows images. Applies to build and release workflows for Docker Hub and GHCR. Attestations remain on the -linux tag.

Validated locally with the failing build's images: all seven Linux and two Windows entries are retained. Full publication has not been rerun.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary by CodeRabbit

  • Chores
    • Updated container image publishing for Docker Hub and GitHub Container Registry to select Linux image variants explicitly. Windows image variants continue to be included separately. This change applies consistently across the build and publishing workflows, with no changes to the available image platforms or user-facing functionality.

Walkthrough

Both Docker image publishing workflows now filter manifest digests by platform.os == "linux" for Docker Hub and GHCR. The build workflow continues to add Windows manifest entries separately.

Changes

Manifest publishing

Layer / File(s) Summary
Linux digest selection
.github/workflows/build-docker-image.yml, .github/workflows/publish-docker-image.yml
Docker Hub and GHCR manifest steps now select digests only from entries with platform.os == "linux". The build workflow adds Windows entries separately.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: gesellix, kyleaure

Merge Risk: Minimal · up to 4b1d8

This change stops attestation entries from breaking multi-platform image publication by selecting only runnable Linux images. No concrete merge risk was found. Confirm the next publication run succeeds.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the CI fix that excludes attestations when combining image manifests. The raw summary describes the change as selecting only linux-OS manifest digests before combining…
Description check Passed The description states the fix: selecting only runnable Linux images before combining them with Windows images for the Docker Hub and GHCR workflows. It names the failing error text, links the failing…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the CI fix that excludes attestations when combining image manifests. The raw summary describes the change as selecting only linux-OS manifest digests before combining them, and the description says the same. The title says attestations are excluded, which matches the stated objective. The title and the summary use different framing, so the title is a fair but slightly indirect match to the file-level change. This is a PASS.

Full details: Description check

Explanation

The description states the fix: selecting only runnable Linux images before combining them with Windows images for the Docker Hub and GHCR workflows. It names the failing error text, links the failing build, notes that attestations stay on the -linux tag, and reports local validation. This matches the changed workflow files. This is a PASS.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the manifest rows,
And picks the Linux digest as it goes.
Docker Hub and GHCR align,
Their Linux entries now define the line.
Windows stays a separate track,
The rabbit hops, then checks it back.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bf9b1788-1534-46e1-920e-6c00f930a272
Commits

Reviewing files that changed from the base of the PR and between 0509b37 and 4b1d84a.

Files selected for processing: 2

  • .github/workflows/build-docker-image.yml
  • .github/workflows/publish-docker-image.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@ilopezluna
ilopezluna marked this pull request as ready for review November 14, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant