Repository navigation
docs: make the release checklist set OUTRIG_REQUIRE_ENTER - #735
Merged
Merged
Conversation
RELEASING.md's dry-run and publish commands did not set OUTRIG_REQUIRE_ENTER. Without it, crates/outrig/build.rs turns a launcher it cannot build -- the musl target missing, or src/container/enter/launcher.rs absent from the archive -- into one cargo warning and an empty artifact. The verify build is the only build of the archive's own sources, so such a crate passed the dry-run, and a publish would have gone ahead with every view = "primary" sidecar failing at session start. CI's package job sets the variable; the checklist a releaser works down did not. Both commands now take OUTRIG_REQUIRE_ENTER=1, as does the publish-separately fallback. The dry-run says why once and links CONTRIBUTING.md#packaging rather than repeating it. "Before you start" gains the musl target, which the variable makes a hard prerequisite on the releasing machine. Fixes #641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.md's dry-run and publish commands did not set OUTRIG_REQUIRE_ENTER. Without it, crates/outrig/build.rs turns a launcher it cannot build -- the musl target missing, or src/container/enter/launcher.rs absent from the archive -- into one cargo warning and an empty artifact. The verify build is the only build of the archive's own sources, so such a crate passed the dry-run, and a publish would have gone ahead with every view = "primary" sidecar failing at session start. CI's package job sets the variable; the checklist a releaser works down did not.
Both commands now take OUTRIG_REQUIRE_ENTER=1, as does the publish-separately fallback. The dry-run says why once and links CONTRIBUTING.md#packaging rather than repeating it. "Before you start" gains the musl target, which the variable makes a hard prerequisite on the releasing machine.
Fixes #641
Summary
What does this change, and why?
Checklist
cargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warningsis cleancargo test --workspacepassesdoc/updated if behavior changed (mdbook buildstill clean)Notes for reviewers
Anything worth calling out -- tricky bits, follow-ups, or intentionally out-of-scope items.