fix(api): satisfy clippy 1.96 unnecessary_sort_by (unblock main)#63
Merged
Conversation
The new clippy step runs under rust-toolchain@stable, which is now 1.96; its unnecessary_sort_by lint flagged two descending `sort_by(|a,b| b.len.cmp(&a.len))` calls that my local 1.94 clippy didn't have. Switch both to the suggested `sort_by_key(|b| Reverse(b.points.len()))` — identical (stable) ordering. Verified clean with clippy 1.96. Fixes the red server job that's blocking the image build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
serverjob went red the moment clippy landed (#61):rust-toolchain@stableis now 1.96, whoseunnecessary_sort_bylint flags two descendingsort_by(|a,b| b.points.len().cmp(&a.points.len()))calls inapi.rsthat my local 1.94 clippy didn't have. Becauseimageneedsserver, the JEF-87 image build was skipped entirely.Fix: both sites →
sort_by_key(|b| std::cmp::Reverse(b.points.len()))(clippy's own suggestion; identical stable ordering). Verified clean locally afterrustup update stableto 1.96:cargo clippy --locked --all-targets -- -D warnings→ EXIT 0,cargo fmt --checkclean.🤖 Generated with Claude Code