Bump base image to Alpine 3.24 for amd64 and arm64 - #721
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the container base images for amd64 and arm64 to Alpine 3.24 and adjusts the bundled nginx default site config to avoid the deprecated listen ... http2 syntax.
Changes:
- Bump
ghcr.io/linuxserver/baseimage-alpine-nginxfrom3.19→3.24forlinux-amd64.Dockerfile. - Bump
ghcr.io/linuxserver/baseimage-alpine-nginxfromarm64v8-3.19→arm64v8-3.24forlinux-arm64.Dockerfile. - Update nginx default server config to use
http2 on;instead oflisten ... http2;.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| linux-arm64.Dockerfile | Updates arm64 base image tag to Alpine 3.24. |
| linux-amd64.Dockerfile | Updates amd64 base image tag to Alpine 3.24. |
| docker/root/defaults/nginx/site-confs/default.conf | Switches to the newer http2 on; directive to address nginx deprecation warnings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+5
to
+7
| listen 443 ssl; | ||
| listen [::]:443 ssl; | ||
| http2 on; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Description:
Bump the base image version to alpine 3.24 for amd64 and arm64
Benefits of this PR and context:
Support for the Alpine 3.19 base image ended eight months ago. Updating to Alpine 3.24 ensures continued access to security fixes.
This MR also updates the nginx configuration to address a deprecation warning. However, the armv7 image still uses an older nginx version that does not support this change. Since the armv7 images are deprecated and will no longer receive new base image versions, I would appreciate maintainer feedback on how armv7 should be handled going forward.
Link
How Has This Been Tested?
I built the new image on my amd64 machine, checked the logs, and tested it with Sonarr.