Repository navigation
🤖 fix(web): show compact fallback until AdSense slot is filled and cap height at 90px - #44
Merged
Merged
Conversation
Deploying sc-controller-mapper with
|
| Latest commit: |
65d6db7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b81a246d.sc-controller-mapper.pages.dev |
| Branch Preview URL: | https://fix-adsense-filled-swap.sc-controller-mapper.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-ad-status === "filled"Check):scbind.com, Google AdSense'sadsbygoogle.jsprocesses<ins class="adsbygoogle">(data-adsbygoogle-status="done"), resizes the<ins>element to280pxtall whendata-ad-format="auto"is used, and leavesdata-ad-statusunset (null) while a newly created ad unit (9700539154) warms up or when no ad impression is served.AdSenseSlot(apps/web/src/components/MonetizationSlot.tsx) so the compact Aegis Flight Systems fallback card remains visible untilMutationObserverobservesdata-ad-status="filled", keeping the<ins>wrapper collapsed (0pxheight) until a real ad is filled.90px:data-ad-format="horizontal"anddata-full-width-responsive="false"withmaxHeight: '90px'so Google's script cannot expand the slot to280pxtall.🤖 AI Agent / LLM Contribution Disclosure
https://scbind.com/to diagnose why the AdSense slot rendered as a 280px blank box and updateAdSenseSlotto keep the compact fallback card visible untildata-ad-status="filled"while capping the ad unit height at90px.apps/web/src/components/__tests__/MonetizationSlot.spec.tsx).npm run build).