Repository navigation
feat: Dedicated reset view, undo and delete map buttons - #664
Merged
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jessicamcinchak
approved these changes
Sep 30, 2026
jessicamcinchak
left a comment
jessicamcinchak
left a comment
Member
There was a problem hiding this comment.
Again works exactly as expected on Storybook - thanks !
| image.src = trashCanIcon; | ||
| button.appendChild(image); | ||
| } | ||
| if (icon) button.appendChild(makeIcon(icon)); |
Member
There was a problem hiding this comment.
Nice to retire lingering unicode here 😅 💅
| */ | ||
| export function resetControl(listener: () => void) { | ||
| return makeButtonControl("reset-control", makeResetButton(listener)); | ||
| } |
Member
There was a problem hiding this comment.
Nice and flexible, thanks for accounting for various "modes" here 🙌
|
|
||
| /** | ||
| * @deprecated - the reset control always uses the "filter center focus" icon now, and deleting drawings is handled by the separate delete control | ||
| */ |
Member
There was a problem hiding this comment.
We've been doing alpha pre-releases, so these deprecation notes are perfect 👍
Member
Author
|
Thanks for the review @jessicamcinchak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates UI for map functionality:
reset viewfunction fromdelete all pointsreset viewsits with view controlsdelete pointsas separate functionIntroduceundo last operationfunction (which also works to restore deleted points)