ASoC: SOF: add SOF_DBG_CHECK_SDW_PERIPHERAL debug flag#5741
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new SOF debug flag to optionally wait for SoundWire enumeration and filter out “ghost” peripherals listed in ACPI, avoiding machine-driver selection based on non-existent devices.
Changes:
- Introduces
SOF_DBG_CHECK_SDW_PERIPHERALdebug flag. - Adds an optional enumeration wait/verification step in
hda_sdw_machine_select()before generating ACPI link/ADR structures. - Adds a local enumeration timeout constant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| sound/soc/sof/sof-priv.h | Adds a new SOF debug flag definition controlling SoundWire peripheral presence checks. |
| sound/soc/sof/intel/hda.c | Implements the optional wait-for-enumeration logic during SoundWire default machine selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bardliao
force-pushed
the
for-sdw-ghost
branch
2 times, most recently
from
c2f293d to
21ea49d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
If the flag is set, the driver waits for and verifies the presence of SoundWire peripherals listed in the ACPI table. This prevents the system from probing non-existent (ghost) SoundWire devices. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
|
@naveen-manohar @udaymb Could you check if this PR meet your requirement? |
If the flag is set, the driver waits for and verifies the presence of SoundWire peripherals listed in the ACPI table. This prevents the system from probing non-existent (ghost) SoundWire devices.