schedule: zephyr_dp_sched_app: fix build error in release builds#10954
Open
kv2019i wants to merge 1 commit into
Open
schedule: zephyr_dp_sched_app: fix build error in release builds#10954kv2019i wants to merge 1 commit into
kv2019i wants to merge 1 commit into
Conversation
Release build fail when building with DP user-space implementation. Build fails as CONFIG_THREAD_MAX_NAME_LEN is not defined. Problem not affecting when building with debug enabled, and/or configurations where the feature is disabled. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
LaurentiuM1234,
dbaluta,
marcinszkudlinski and
pblaszko
as code owners
kv2019i
requested review from
abonislawski,
jsarha,
lyakh,
softwarecki and
wjablon1
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a release-build compilation failure in the Zephyr DP user-space scheduler path by avoiding use of a thread-name-length Kconfig symbol when thread naming support is disabled.
Changes:
- Guard DP thread naming code with
#ifdef CONFIG_THREAD_NAMEto prevent referencingCONFIG_THREAD_MAX_NAME_LENwhen unavailable.
Comment on lines
414
to
423
| static void scheduler_dp_thread_name_set(k_tid_t thread_id, struct processing_module *mod) | ||
| { | ||
| #ifdef CONFIG_THREAD_NAME | ||
| char name[CONFIG_THREAD_MAX_NAME_LEN]; | ||
|
|
||
| snprintf(name, sizeof(name), "DP:%#x", mod->dev->ipc_config.id); | ||
|
|
||
| k_thread_name_set(thread_id, name); | ||
| #endif | ||
| } |
jsarha
approved these changes
Jun 24, 2026
jsarha
left a comment
jsarha
left a comment
Contributor
There was a problem hiding this comment.
Stupid that due to lacking CONFIG_THREAD_MAX_NAME_LEN definition we need to ifdef code out, bu it is what it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release build fail when building with DP user-space implementation. Build fails as CONFIG_THREAD_MAX_NAME_LEN is not defined. Problem not affecting when building with debug enabled, and/or configurations where the feature is disabled.