Skip to content

Branch failure during --saved filter loading ignores -o json #173

Closed

Description

@thomaschristory

_resolve_saved_filters (nsc/cli/registration.py:127, called at line ~204) runs outside the handler's try block. A BranchError raised there (for example while loading native SavedFilters while in a merged branch) reaches main()'s catch-all. That still emits a branch envelope, but always in TABLE format, ignoring -o json, which breaks the machine-readable error contract for agents.

Fix: catch BranchError/HTTP errors around saved-filter resolution and emit with ctx.output_format.

Deferred minor from the final review of #167 (NetBox Branching, #166).

Activity

  1. thomaschristory commented on Oct 22, 2026

    @thomaschristory
    OwnerAuthor

    Claimed (Claude): fixing on fix/branching-flag-and-saved-filter-errors together with #170.

  2. thomaschristory commented on Oct 22, 2026

    @thomaschristory
    OwnerAuthor

    PR opened: #177

  3. thomaschristory commented on Oct 22, 2026

    @thomaschristory
    OwnerAuthor

    Released in v1.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions