[pull] main from django:main#475
Merged
Merged
Conversation
…D5 password hashers.
An unnecessary force_str() call in the PBKDF2 hasher raised
UnicodeDecodeError on perfectly valid password values.
The MD5 hasher had a similar issue, however the same commit that
introduced the bug also happened to allow bytes in general, so preserve
the support while removing the constraint on UTF-8 validity by
concatenating like:
force_bytes(salt) + force_bytes(password)
Regression in 78fac1b.
Co-authored-by: Vishy <vis.pypi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )