Repository navigation
Don't classify user-defined SAS formats as dates by prefix - #860
Merged
Merged
Conversation
Short date format names (`DAY`, `WEEK*`, `MON*`, `QTR`, `YEAR`) added in #790 now only match when followed by a format width or decimal point, so a user-defined format like `DAYSV` no longer causes a numeric column to be read as `Date` (revdep failure in libr).
Member
Author
|
FWIW I'm planning to submit haven to CRAN on Nov 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Written by AI 🤖
The prefix matching added in #790 classified any SAS format starting with a short date format name as a date, so a column with the user-defined format
DAYSVwas read asDateinstead ofnumeric(revdep failure in libr, #859).Short date format names (
DAY,WEEK*,MON*,QTR,YEAR) now only match when followed by a width digit, a decimal point, or nothing (DAY2.matches,DAYSVdoesn't). Longer unambiguous prefixes likeMMDDYYkeep loose matching so separator variants likeMMDDYYS10.keep working.Verified against libr's test suite, which now passes.