Move webhooks management-cluster rendering into the enterprise extension - #5164
Merged
caseydavenport merged 1 commit intoAug 13, 2026
Merged
Conversation
Brian-McM
approved these changes
Aug 13, 2026
The base webhooks render no longer reads the variant to decide on the ManagedCluster webhook, its flags, or the tunnel secret RBAC.
caseydavenport
force-pushed
the
casey-devariant-webhooks
branch
from
August 13, 2026 20:37
5f5c8a5 to
6f12dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #4871, for CORE-13338.
The webhooks render was still branching on the variant to decide which management-cluster objects, flags and RBAC to add. All of that moves to the enterprise extension, so the base render is variant-blind and the apiserver controller no longer reads the variant at all. Behavior is unchanged, including the cleanup of the tunnel secret RBAC when the cluster isn't a management cluster or the operator is running as Calico.