Mount host /proc into calico-node at /host/proc - #5165
Open
radixo wants to merge 1 commit into
Open
Conversation
Felix's pod-netns resolution reaches host-mount-namespace paths (pod netns files, the CRI socket) through host PID-1's root at /host/proc/1/root, which works regardless of calico-node's PID namespace and does not require hostPID=true. Mount the host's /proc into calico-node at /host/proc (read-only), reusing the existing "nodeproc" HostPath(/proc) volume. The existing hostPID=true usage for process-path collection is left as-is; converging it is a separate Enterprise follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Companion Calico PR: projectcalico/calico#13501 (Felix pod-netns resolution). Follow-up (stacked on this one): the CNI-annotations ValidatingAdmissionPolicy delivery + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to the calico-side "Resolve pod netns in Felix" change (implements design tigera/designs#62). Felix's new pod-netns resolution reaches host-mount-namespace paths (pod netns files, the CRI socket) through host PID-1's root at
/host/proc/1/root, which works regardless of calico-node's PID namespace and does not requirehostPID=true.This PR bind-mounts the host's
/procinto calico-node at/host/proc(read-only), reusing the existingnodeprocHostPath(/proc) volume. The existinghostPID=trueusage for process-path collection is left as-is; converging it is a separate Enterprise follow-up.pkg/render/node.go(+ node render test). No API change.ValidatingAdmissionPolicydelivery and theInstallation.spec.cniAnnotationsPolicytoggle land in a follow-up PR stacked on this one.Release Note
🤖 Generated with Claude Code