Degrade instead of deleting the Goldmane CR on Enterprise - #5167
Open
caseydavenport wants to merge 5 commits into
Open
Degrade instead of deleting the Goldmane CR on Enterprise#5167caseydavenport wants to merge 5 commits into
caseydavenport wants to merge 5 commits into
Conversation
caseydavenport
changed the title
Brian-McM
approved these changes
Aug 13, 2026
The enterprise installation extension now owns the delete, so the core controller no longer gates the Goldmane lookup on the variant.
The operator never deletes operator.tigera.io resources; docs/principles.md now states that.
caseydavenport
force-pushed
the
casey-goldmane-cleanup
branch
from
August 13, 2026 22:06
c8fa2fb to
49aa2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #4871, for CORE-13339.
Goldmane is Calico-only, but nothing noticed it when an installation switched to Calico Enterprise: the Goldmane controller doesn't look at the variant, and the core installation controller only gated its own lookup so that calico/node stopped getting the host alias. The enterprise installation extension now sets degraded when a Goldmane resource is present, naming the resource the user has to delete, and the core controller reads the CR regardless of variant.
The operator doesn't delete the resource itself, since
operator.tigera.ioCRs are user input, whichdocs/principles.mdnow says explicitly.