tools: add a CLI for keyspace GC barriers - #11223
Conversation
Provide show, set, and delete commands for keyspace GC barriers so operators can inspect retention constraints and update timestamps and lifetimes without changing applications. Require an explicit keyspace and TTL, accept decimal TSO and RFC3339 input, and preserve TSO precision in JSON output. Include CLI tests, NextGen PD integration coverage, and usage documentation. Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-20251011 #11223 +/- ##
============================================================
- Coverage 78.73% 78.66% -0.07%
============================================================
Files 491 492 +1
Lines 66124 66498 +374
============================================================
+ Hits 52060 52313 +253
- Misses 10308 10425 +117
- Partials 3756 3760 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What problem does this PR solve?
A stale TiCDC GC barrier can prevent obsolete data from being reclaimed. Operators need a way to inspect, update, and delete individual barriers so they can control how much history becomes eligible for GC.
This is a review-only draft and is not intended to be merged. The implementation is based on
v8.5.4-nextgen.202510.7and uses that version's existing PD gRPC APIs.Issue Number: None (review-only draft).
What is changed and how does it work?
Check List
Tests
go test -tags nextgen,without_dashboard,integration ./pd-gc-barrier -count=1 -timeout=5mfromtools/, with failpoints enabled and then disabled.golangci-lintpassed for the tool and its tests.Release note