fix(settings): centre the content column and quiet the dividers - #88
Open
winetree94 wants to merge 1 commit into
Open
fix(settings): centre the content column and quiet the dividers#88winetree94 wants to merge 1 commit into
winetree94 wants to merge 1 commit into
Conversation
Two things the settings surface still got wrong. The content column sat against the leading edge. On a wide window that leaves it stranded with a growing void beside it, so it is centred now. Below the cap the column fills its pane and the change is a no-op, which is what a list-detail detail pane wants; both cases are pinned by a test. Dividers were drawn at the default TRSeparator variant, which resolves to controlBorder — the weight a control draws at, not a surface. Beside a TRCard outlined in `border` that read as a brighter line through a quieter frame: 163 against 64 in dark, 115 against 212 in light. Every divider in settings is muted now, so a card and the lines inside it close on the same colour.
winetree94
enabled auto-merge
August 6, 2026 15:42
auto-merge was automatically disabled
August 6, 2026 23:32
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two things the settings surface still got wrong after #77 and #83.
The content column sat against the leading edge. The width cap keeps a label and its control near each other, but left-aligning the capped column strands it against one side of a wide window with a growing void beside it. It is centred now. Below the cap the column fills its pane and the change is a no-op — which is what a list-detail detail pane wants — and both cases are pinned by tests.
Dividers were drawn at the default
TRSeparatorvariant, which resolves tocontrolBorder: the weight a control draws at, not a surface. Beside aTRCardoutlined inborderthat read as a brighter line running through a quieter frame — 163 against 64 in dark, 115 against 212 in light. Every divider in settings is muted now, so a card and the lines inside it close on the same colour.Note
This commit was written before #83 merged but could not be pushed at the time: the branch was locked while queued for merging, and I then lost it to a hard reset. Recovered from the object store and rebased onto current
main; the goldens are regenerated on top of #84.The divider change becomes a no-op once tinyrack-net/design#444 lands, since that unifies
borderandcontrolBorder. It is kept because it states the intent — a divider is a surface — and stays correct if the two ever diverge again.Verification
dart run melos verify— 12/12.