Skip to content

Fix QUIC Preferred Address port serialization - #253

Open
sean0407 wants to merge 1 commit into
tls-attacker:mainfrom
sean0407:codex/tls-attacker-248-port-width-20261019
Open

sean0407 wants to merge 1 commit into
tls-attacker:mainfrom
sean0407:codex/tls-attacker-248-port-width-20261019

Conversation

@sean0407

Copy link
Copy Markdown

Summary

  • Serialize the IPv4 and IPv6 Preferred Address ports as two-byte big-endian values.
  • Add a regression test that round-trips a 41-byte Preferred Address containing nonzero port bytes.

Evidence

Issue #248 reports that PreferredAddress.serialize() emits each 16-bit port as one byte, producing a 39-byte result instead of 41 bytes. The new regression test reproduced that exact 41-versus-39 failure before the fix and passes with the corrected encoding.

Changed files:

  • TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/protocol/message/extension/quic/QuicTransportParametersExtensionMessage.java
  • TLS-Core/src/test/java/de/rub/nds/tlsattacker/core/protocol/message/extension/quic/QuicTransportParameterTest.java

Checks:

  • Isolated Docker Maven run: mvn -o -B -Dstyle.color=never -pl TLS-Core -am -Dtest=QuicTransportParameterTest -Dsurefire.failIfNoSpecifiedTests=false test — passed, 3 tests.
  • git diff --check — passed.
  • scripts/patch_policy.py — accepted 2 files, 18 changed lines, no binary changes.

Fixes #248

Merge Danger

Door: two-way

Blast Radius: localized to QUIC Preferred Address serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in QuicTransportParametersExtensionMessage.PreferredAddress.serialize()

1 participant