Skip to content

Fix QUIC Preferred Address connection ID length - #254

Open
sean0407 wants to merge 1 commit into
tls-attacker:mainfrom
sean0407:codex/tls-attacker-247-connection-id-length-20261019
Open

sean0407 wants to merge 1 commit into
tls-attacker:mainfrom
sean0407:codex/tls-attacker-247-connection-id-length-20261019

Conversation

@sean0407

Copy link
Copy Markdown

Summary

Use the configured connectionIdLength when serializing a QUIC Preferred Address, so callers can control the advertised length independently of the connection ID bytes.

Evidence

  • Reproduction: construct a Preferred Address with a two-byte connection ID, set connectionIdLength to 3, and serialize it. Before the fix, the advertised length byte is 2; the focused regression test failed with expected: <3> but was: <2>.
  • Changed files:
    • TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/protocol/message/extension/quic/QuicTransportParametersExtensionMessage.java
    • TLS-Core/src/test/java/de/rub/nds/tlsattacker/core/protocol/message/extension/quic/QuicTransportParameterTest.java
  • Checks: focused Maven test passed (3 tests, 0 failures/errors); git show --check passed; patch policy accepted 2 text files and 21 changed lines.

Merge Danger

The wire length byte now follows the explicitly configured field when it differs from the payload array length. This is the behavior required to serialize intentionally modified protocol values; ordinary values where the lengths match are unchanged.

Fixes #247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in QuicTransportParametersExtensionMessage.PreferredAddress.serialize()

1 participant