Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.createCopy()serializes and unmarshals configuration through JAXB:JAXB could not instantiate
PreferredAddress, and itsInetAddressproperties were not JAXB-compatible. The change adds a no-argument constructor and maps both addresses to their raw bytes for the configuration round trip.Changed files:
TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/protocol/message/extension/quic/QuicTransportParametersExtensionMessage.javaTLS-Core/src/test/java/de/rub/nds/tlsattacker/core/config/PreferredAddressConfigCopyTest.javaFixes #252.
Evidence
Config.createCopy()reproduction failed withNoSuchMethodExceptionforPreferredAddress.<init>().mvn -o -B -pl TLS-Core -am '-Dtest=PreferredAddressConfigCopyTest,QuicTransportParameterTest' -Dsurefire.failIfNoSpecifiedTests=false testpassed (3 tests).Merge Danger
Door: Two-way
Blast Radius: Low
This changes JAXB mapping for QUIC preferred-address IPv4/IPv6 values in configuration copies. The adapter preserves each address as raw address bytes.