Repository navigation
chore: fix jsdoc lint warnings and split merged .gitignore pattern - #15
Merged
Merged
Conversation
- add the missing @PARAM result.data / result.header entries for destructured parameters, give @throws a type, drop stray asterisks in a doc comment - .gitignore had '*.tgz*.tsbuildinfo' on one line, so neither *.tgz nor *.tsbuildinfo was ignored; split into two patterns eslint: 19 warnings -> 11 (the remaining are 2 complexity and 9 nested-callback warnings, left alone as they need refactoring, not lint fixes). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GP39ZPN7EzLLdoKcJkGD4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small, behaviour-free cleanup split out of the BAP Best of Show work so that PR stays focused.
Type of Change
Changes Made
@param result.data/@param result.headerentries for destructured parameters (competitions.tsx2,bcoem-parser.test.ts).@throwsa type (bcoem-results.ts,fetch.test.ts).bcoem-dates.ts)..gitignorehad*.tgz*.tsbuildinfoon one line, so neither*.tgznor*.tsbuildinfowas actually ignored (tsconfig.tsbuildinfoshowed as untracked after a build). Split into two patterns.eslint (after
npm run build): 19 warnings -> 11, 0 errors. The 11 left are 2complexityand 9max-nested-callbackswarnings, deliberately not touched here since they need refactoring rather than lint fixes.Platform(s) Affected
Testing
npm test): 557 passingChecklist
Documentation
No docs/CHANGELOG change needed (no user-visible behaviour).
Generated by Claude Code