Skip to content

Create venv with ensurepip on Windows #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgirardeau merged 2 commits into from
Jul 12, 2026
Merged

Create venv with ensurepip on Windows #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e5b100
Create venv with ensurepip on Windows
rjanvier Jul 11, 2026
bdbddf3
format
rjanvier Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/PythonRuntimeSettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@

#include <memory>

namespace py = pybind11;

/// Simple Dialog that displays a Line Edit with a button next to it
/// to let the user select a path to a directory
class PathVariableInputDialog final : public QDialog
Expand Down Expand Up @@ -275,7 +277,18 @@ void PythonRuntimeSettings::handleCreateVenv()

try
{
const auto createVenvFn = pybind11::module_::import("venv").attr("create");
// On Windows we create the venv with ensurepip, to allow users to use the "Package Manager" GUI
// with the newly created venv. ensurepip is only "sure" on Windows, Linux distro packages do not
// "ensure" ensurepip (sic.). On macOS it should be sure, but macOS bundle has some quirks, so we
// stay conservative for now.
#if defined(Q_OS_WINDOWS)
const py::module_ venvModule = py::module_::import("venv");
const py::object envBuilder = venvModule.attr("EnvBuilder");
const py::object builder = envBuilder(py::arg("with_pip") = true);
const auto createVenvFn = builder.attr("create");
#else
const auto createVenvFn = py::module_::import("venv").attr("create");
#endif
createVenvFn(path);
}
catch (const std::exception &e)
Expand Down
Loading