Fix console crash on macOS - #183
Merged
Merged
Conversation
ConsoleWrapper constructor move the lambda. As as result it's unsafe to capture 'this' because the instance of this is eventually destroyed when it goes out of scope (it's a "temporary"). Don't know why it was unotticed on Linux/Windows. The PR removes also a usesless member and fixes a constructor (QColor passed but not used tho init the brush)
tmontaigu
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CloudCompare/CloudCompare#2357
ConsoleWrapper constructor move the lambda. As as result it's unsafe to capture 'this' because the instance of this is eventually destroyed when it goes out of scope (it's a "temporary").
Don't know why it went unnoticed on Linux/Windows.
The PR removes also a usesless member and fixes a constructor (QColor passed but not used to init the Brush)