feat(our-work): add our work page with table, filters and query#3
Open
AmritBhusal wants to merge 3 commits into
Open
feat(our-work): add our work page with table, filters and query#3AmritBhusal wants to merge 3 commits into
AmritBhusal wants to merge 3 commits into
Conversation
AmritBhusal
requested review from
crsstha,
shreeyash07 and
subinasr
and removed request for
shreeyash07 and
subinasr
shreeyash07
requested changes
Jun 15, 2026
| index: true, | ||
| path: '/our-works', | ||
| load: () => import('#views/OurWorks'), | ||
| path: '/OurWorks', |
Contributor
There was a problem hiding this comment.
no need to make change in path revert it back and revert to its children paths
| type FormSchema = ObjectSchema<PartialFormType>; | ||
| type FormSchemaFields = ReturnType<FormSchema['fields']>; | ||
|
|
||
| const getWorksSchema = (): FormSchema => ({ |
Contributor
There was a problem hiding this comment.
We don't need to make this schema a function like in user page.
| const navigate = useRouting(); | ||
| const alert = useAlert(); | ||
|
|
||
| const worksSchema = useMemo(() => getWorksSchema(), []); |
Contributor
There was a problem hiding this comment.
No need to this here, you can send workSchema directly to useForm
| showOnHome: false, | ||
| }; | ||
|
|
||
| const pageKeySelector = (item: { key: string }) => item.key as DashboardPage; |
Contributor
There was a problem hiding this comment.
you existing keySelector
Comment on lines
+34
to
+49
| function StatusCell({ isActive }: { isActive: boolean }) { | ||
| return ( | ||
| <ListView | ||
| layout="inline" | ||
| spacing="sm" | ||
| > | ||
| <span | ||
| className={isActive | ||
| ? 'status-indicator-active' | ||
| : 'status-indicator-inactive'} | ||
| /> | ||
| <span>{isActive ? 'Active' : 'Inactive'}</span> | ||
| </ListView> | ||
| ); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Lets create this a separate component and reuse this in users page also
| offset, | ||
| }, | ||
| filters: { | ||
| isActive: filter.isActive !== undefined ? filter.isActive === 'true' : undefined, |
| }); | ||
| const [, deleteExternalDashboard] = useDeleteExternalDashboardMutation(); | ||
|
|
||
| const pageSize = limit; |
Contributor
There was a problem hiding this comment.
useFilterState gives you page size please look, if not you can assigned above no need to make new const variables
AmritBhusal
force-pushed
the
feature/our-work
branch
from
3266574 to
989c4ef
Compare
crsstha
approved these changes
Jun 17, 2026
shreeyash07
requested changes
Jun 17, 2026
Comment on lines
+35
to
+45
| export interface WorksFilterType { | ||
| isActive: string | undefined; | ||
| page: string | undefined; | ||
| search: string | undefined; | ||
| } | ||
|
|
||
| const defaultFilter: WorksFilterType = { | ||
| isActive: undefined, | ||
| page: undefined, | ||
| search: undefined, | ||
| }; |
Contributor
There was a problem hiding this comment.
Lets use filter type from generated types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any
console.logmeant for debugging