Team members page#4
Open
shreeyash07 wants to merge 4 commits into
Open
Conversation
shreeyash07
requested review from
AdityaKhatri,
AmritBhusal,
crsstha and
subinasr
AmritBhusal
reviewed
Jun 15, 2026
AmritBhusal
reviewed
Jun 15, 2026
| const [{ fetching: updatePending }, updateTeamMemberMutate] = useUpdateTeamMemberMutation(); | ||
|
|
||
| const handleMutation = useCallback(async (mutationData: PartialFormType) => { | ||
| const redirectPath = 'teams'; |
There was a problem hiding this comment.
it is redirecting to teams list but user will be working on specific team so shouldn't it should send user back to that specific team similar to how it has handeled in cancel?
navigate('teamMembers', { id });
AmritBhusal
reviewed
Jun 15, 2026
AmritBhusal
reviewed
Jun 15, 2026
AmritBhusal
reviewed
Jun 15, 2026
| <ListView layout="block"> | ||
| <InputSection | ||
| title="Team name" | ||
| description="Enter the name of the user" |
There was a problem hiding this comment.
in description instead of user wouldn't be better to write team member as this is team member page specifically
AmritBhusal
reviewed
Jun 15, 2026
| </InputSection> | ||
| <InputSection | ||
| title="Email" | ||
| description="Enter the email of the user" |
There was a problem hiding this comment.
Similalry here too instead of user Enter the email of member/ team member something like this on all description fields
crsstha
reviewed
Jun 17, 2026
| setPage, | ||
| pageSize, | ||
| variables, | ||
| } = usePagination(); |
Collaborator
There was a problem hiding this comment.
use this hook UseFilterState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends upon: toggle-corp/ercs-backend#16
Changes
This PR doesn't introduce any
console.logmeant for debugging