Repository navigation
Split run_task() into claim_task() and run_claimed_task() - #60
Merged
Merged
Conversation
run_task() claimed the task and ran it in one call. A worker that fetches tasks in one thread and runs them in another needs the claim in the fetching thread, so that its next fetch does not return the same READY row, and the run elsewhere. The two steps are now public methods and run_task() calls one and then the other; nothing that calls run_task() changes, and the existing tests pass unmodified. Refs #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ahead of `--threads M` (#25). `run_task()` claimed the task and ran it in one call. A worker that fetches in one thread and runs in another needs the claim in the fetching thread, so that its next `fetch_task()` does not hand it the same READY row again, and the run in the executor thread.
`DatabaseTaskBackend` gains two public methods, and `run_task()` becomes one followed by the other:
Nothing that calls `run_task()` changes, and the existing tests pass unmodified on Python 3.13 / Django 6.0 and Python 3.14 / Django 6.1 with `-W error::DeprecationWarning`. Three tests are added for the two methods on their own and for `run_task()` being the two of them. A CHANGELOG line notes the new methods; existing projects need no changes.
Refs #25