Repository navigation
Say up front to prefer processes over threads - #62
Merged
Merged
Conversation
The advice was in the last bullet of the trade-offs; a reader choosing between --workers and --threads should meet it before the table. Refs #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only. The Running several workers section listed three tiers and left the recommendation to the last bullet of Trade-offs. It now opens with it: prefer processes, whether a process manager or `--workers` keeps them running, unless the memory of N processes is what you cannot afford and the tasks are I/O-bound and thread-safe. The trade-offs bullet points back to it instead of repeating it, and the CHANGELOG entry for `--threads` under Unreleased mentions the advice. No code changes.
Refs #25