Repository navigation
Refuse a negative --days in purge_completed_database_tasks - #70
Merged
Merged
Conversation
The command treated a negative --days like --days 0 and deleted every completed task, while purge_completed_tasks() and the purge endpoint refuse a negative value. It now raises CommandError before it counts or deletes anything. Fixes #69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purge_completed_database_taskstreated a negative--dayslike--days 0and deleted every completed task, whilepurge_completed_tasks()and the purge endpoint refuse a negative value. The command now raisesCommandErrorbefore it counts or deletes anything, with the same message aspurge_completed_redis_tasksin django-tasks-redis.--days 0, positive values and the default are unchanged, so existing projects need no changes. The README and CHANGELOG are updated, and a new test covers the refusal.Fixes #69