HOTFIX-PM5755: Resolve phase-name-only reviewer defaults - #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phaseNamefrom the default-reviewer API response.Root cause
The follow-up to #2161 correctly requested defaults for the selected timeline, but the live default-reviewer records identify their phases with
phaseName; theirphaseIdvalues are null. Platform UI discardedphaseName, so every default fell back to the same challenge phase. The completeness check then treated the other required phases as unavailable and left the hidden reviewer rows unchanged, which caused draft validation to report:Assign all required members when public review opportunity is closed.Impact
Two-round Design challenge drafts can resolve all five default reviewer rows. Checkpoint Review, Review, and Approval are assigned to the selected copilot, while Screening and Checkpoint Screening remain optional.
Validation
yarn test:no-watch --runInBand src/apps/work/src/lib/services/challenges.service.spec.ts src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/HumanReviewTab.spec.tsx(39 tests passed)yarn lintyarn run build(passed with existing repository warnings)