fix(qdrant): remove upload_records removed in qdrant-client v1.16.1#4370
fix(qdrant): remove upload_records removed in qdrant-client v1.16.1#4370Goutham-Annem wants to merge 1 commit into
Conversation
….16.1 The upload_records method was removed from QdrantClient and AsyncQdrantClient in qdrant-client v1.16.1. The hasattr guard in _instrument/_uninstrument already prevents the AttributeError at patching time, but the dead code in wrapper.py and the stale entries in the JSON methods files should also be cleaned up. Fixes traceloop#3492 Signed-off-by: Goutham Annem <gouthemannem@gmail.com>
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe Qdrant instrumentation no longer registers ChangesQdrant upload_records instrumentation
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
qdrant-clientv1.16.1 removed theupload_recordsmethod from bothQdrantClientandAsyncQdrantClient. This causes anAttributeErroron instrumentation when the package version constraint allows v1.16.1+.The
_instrumentand_uninstrumentmethods already have ahasattrguard that prevents the crash at patching time, but the method is still listed inqdrant_client_methods.jsonandasync_qdrant_client_methods.json, and there is dead handler code for it inwrapper.py.Changes
upload_recordsentry fromqdrant_client_methods.jsonupload_recordsentry fromasync_qdrant_client_methods.jsonelif method == "upload_records":branch fromwrapper.pyTesting
No test cassettes reference
upload_records. The existing test suite covers the remaining methods and can be verified with:Fixes #3492
Summary by CodeRabbit
upload_recordsoperation.upload_recordswill no longer generate the associated span or upload point-count attribute.