Implement {posterior} - #17
Merged
Merged
Conversation
…rors these are internal functions that make working with the posterior draws nicer. They will be implemented in the model code
…mates even though this is all_draws
benjaminhlina
marked this pull request as ready for review
June 24, 2026 00:47
Collaborator
Author
|
…se_ar() if you end up pulling from the repo
…mate does not make sense - this will likely cause errors down the line in test
…nd the estimate doens't make sense
…s will result in rhat being appropriate
…E in build_pixel_grid()
…w different OS run Stan even with seed set to 4 these do not produce consistent resutls. Alternatively they could be kept and the tolerance turned down a lot but then that feels like that defeats the purpose of the tests
mhpob
reviewed
Jun 24, 2026
… change the reference location in the .Rmd files
…w use `sf::st_is_longlat()`
…I remembered the _ version needs to in build ignore
…it needs to be TRUE to hit warnings and errors.
mhpob
approved these changes
Jun 25, 2026
mhpob
left a comment
mhpob
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I think the version jumped an extra point though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posterior::as_draws_df()instead ofas.data.frame()to get posterior draws.extract_*()functions (internal) which take adraws_dfobject and pull information whether that is summarized draws, draws for latentsxandsyvariables, draws for detection probabilityp0orp0[1, 1]ect., and draws for parameters of the detection probability model e.g.,alpha0andalpha1.all_estimates->all_drawsbut feel like this would change the original vignette.extract_*()functions