Repository navigation
Add .nvmrc pinning Node 22 - #421
Closed
mtheeraj148-netizen wants to merge 1 commit into
Closed
mtheeraj148-netizen wants to merge 1 commit into
mtheeraj148-netizen wants to merge 1 commit into
Conversation
Node 26 (bleeding-edge/unstable) bundles a common.gypi that injects the Clang-only -flto=thin flag, which breaks MSVC linking for native modules (e.g. tree-sitter-kotlin) on Windows. Pin to Node 22 LTS, which the project already requires (package.json: "node": ">=20"), so native builds work out of the box.
🌱 graft blast radiusNothing outside this diff depends on it. 0 areas changed; no indexed dependents at depth 2.
Open the interactive graph → — click an area to see its dependent symbols at file:line. |
Collaborator
|
Thanks! Pinning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcpinning Node22.23.2at the repo root.Why
Node 26 (bleeding-edge/unstable) bundles a
common.gypithat unconditionally injects the Clang-only-flto=thinflag into native-module builds. On Windows with MSVC, this breaks the linker (LNK1117: syntax error in option 'opt:lldltojobs=2') when installing dependencies that require native compilation, such astree-sitter-kotlin.The project already requires
"node": ">=20"inpackage.json; pinning to Node 22 LTS via.nvmrcmakesnpm installwork out of the box for contributors who runnvm use(a common convention manynvm/fnmsetups auto-apply).Test plan
npm installfails on Node 26.8.1 with the LNK1117 linker error buildingtree-sitter-kotlinnpm installsucceeds cleanly on Node 22.23.2 with.nvmrcin place