Repository navigation
feat: expose unresolved call diagnostics and Rust coverage limits - #85
Open
tob-scott-a wants to merge 2 commits into
Open
tob-scott-a wants to merge 2 commits into
tob-scott-a wants to merge 2 commits into
Conversation
tob-scott-a
marked this pull request as ready for review
October 16, 2026 19:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest #73 comment reports thousands of unresolved Rust receivers and asks whether returned types connect subsequent calls. The parser records declared return types and nested call expressions, but does not propagate receiver types through expressions such as
make().unwrap().execute(). This can disconnect a local implementation from reachability despite preserving its call site.Add
trailmark analyze --resolution,QueryEngine.call_resolution(), andunresolved_calls(name=None). The summary distinguishes extracted call sites from distinct proxy targets, counts affected callers, and groups unresolved calls by final syntactic callee label. Detailed rows retain per-call source locations and raw targets, including separate expressions that share an escaped proxy ID.Document the reported standard-method, iterator, conversion, external-library, generated-builder, local-receiver, and enum-constructor patterns, with regression examples for all seven. The README explains that return-type metadata does not resolve later receivers and that opaque macro bodies and implicit calls are outside the report's denominator. The diagnostics do not claim whole-program coverage or add Rust type inference.
Normal graph JSON and summary output stay compatible. The new resolution report is an explicit output mode, mutually exclusive with summary and complexity output.
Validation: 1,421 pytest tests passed; Ruff lint/format and ty passed. Tests cover model classification, endpoint validation, counts versus target identities, caller filtering, per-site locations, CLI output, the seven Rust patterns, and incomplete reachability through returned values. Dependency setup used the checked-in lockfile with uv --frozen because the local global exclude-newer setting predates a required locked dependency.
Refs #73 (comment)