Repository navigation
[pull] master from OpenAPITools:master - #813
Merged
Merged
Conversation
…#25004) * [swift6] Add nonisolatedModels option for default MainActor isolation Adds a `nonisolatedModels` boolean option (default: false) to the swift6 generator. When enabled, generated model structs/classes/enums, the extensions emitted alongside them, and the supporting protocols and helper types they conform to or store (ParameterConvertible, CaseIterableDefaultsLast, UnknownCaseCheckable, NullEncodable, JSONValue, OpenAPIDateWithoutTime, the validation rule structs, CodableHelper, OpenAPIMutex, OpenISO8601DateFormatter, and the ParameterConvertible, CodingKey and Codable container extensions in Extensions.swift) are marked `nonisolated`. This lets the generated sources be vendored into a module built with Swift 6.2 default MainActor isolation (SE-0466) while keeping models decodable and usable off the main actor. Requires a Swift 6.1+ toolchain when enabled; output is unchanged when the option is off. Enabled in the swift6 validation sample. Fixes #24903 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * [swift6] nonisolatedModels: cover objcCompatible models and enum tests Review flagged that objcCompatible model classes were left MainActor-isolated while their Identifiable/UnknownCaseCheckable extensions were marked nonisolated, which fails to compile under default MainActor isolation. Mark the objcCompatible class declaration nonisolated too (verified to build with 0 errors), and add tests for top-level, nested and oneOf enums and objcCompatible. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * [swift6] tests: reuse generateSwift6 helper in nonisolatedModels tests Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )