Repository navigation
[pull] master from ron-rs:master - #39
Merged
Merged
Conversation
* fix(de): accept inf/NaN start bound in compact Range/RangeInclusive The compact-range serializer emits non-finite start bounds such as `inf..2.0` and `NaN..=2.0`, but the `Range`/`RangeInclusive` deserializers only took the compact-range path when the first byte was recognised by `is_number_start` (digit / + / - / . / b). Because `inf` and `NaN` start with a letter, those inputs failed to deserialize with `ExpectedNamedStructLike`, breaking serialize -> deserialize round-trips. The sibling `RangeFrom` branch already had the inf/NaN ident checks; this applies the same checks to `Range`/`RangeInclusive`. * refactor(de): move the compact-range number-start check into the parser The inf/NaN literal check now sits next to any_number as check_any_number_start, so the Range/RangeInclusive and RangeFrom call sites share one definition instead of repeating the same seven-way condition. * docs(changelog): add an Unreleased bug-fix entry for #605 * docs(changelog): say start bound, which is what the fix covers The entry claimed both bounds. Only the start was broken: the guard was is_number_start, which does not recognise inf or NaN, while the end bound already went through any_number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )