Migrate append_lifecycle to TLogPolicy - #1162
Merged
Merged
Conversation
AlCutter
force-pushed
the
migrate_tlog_policy_3
branch
2 times, most recently
from
September 8, 2026 15:09
b68766f to
3157237
Compare
AlCutter
force-pushed
the
migrate_tlog_policy_3
branch
from
September 8, 2026 15:23
3157237 to
7ff023c
Compare
AlCutter
marked this pull request as ready for review
September 8, 2026 16:28
AlCutter
force-pushed
the
migrate_tlog_policy_3
branch
from
September 9, 2026 11:27
7ff023c to
38e50ad
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 002758b | Previous: f1f48c4 | Ratio |
|---|---|---|---|
BenchmarkDedup (github.com/transparency-dev/tessera) |
4657141 ns/op 900392 B/op 18768 allocs/op |
2207022 ns/op 886850 B/op 18650 allocs/op |
2.11 |
BenchmarkDedup (github.com/transparency-dev/tessera) - ns/op |
4657141 ns/op |
2207022 ns/op |
2.11 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) |
9226 ns/op 6528 B/op 1 allocs/op |
1351 ns/op 6528 B/op 1 allocs/op |
6.83 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) - ns/op |
9226 ns/op |
1351 ns/op |
6.83 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) |
139901 ns/op 15382 B/op 180 allocs/op |
56548 ns/op 15353 B/op 180 allocs/op |
2.47 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
139901 ns/op |
56548 ns/op |
2.47 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) |
1547300 ns/op 689078 B/op 3554 allocs/op |
554836 ns/op 689106 B/op 3555 allocs/op |
2.79 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) - ns/op |
1547300 ns/op |
554836 ns/op |
2.79 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) |
166212 ns/op 15475 B/op 180 allocs/op |
56420 ns/op 15411 B/op 180 allocs/op |
2.95 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
166212 ns/op |
56420 ns/op |
2.95 |
This comment was automatically generated by workflow using github-action-benchmark.
AlCutter
force-pushed
the
migrate_tlog_policy_3
branch
from
September 9, 2026 11:31
38e50ad to
05e7891
Compare
roger2hk
approved these changes
Sep 10, 2026
Comment on lines
+841
to
843
| if w.URL == nil { | ||
| return nil, fmt.Errorf("invalid witness policy: witness %q has no URL", w.Name) | ||
| } |
Contributor
There was a problem hiding this comment.
Should we also add the nil check for w.Verifier just in case it is nil?
if w.Verifier == nil {
return nil, fmt.Errorf("invalid witness policy: witness %q has no verifier", w.Name)
}
Collaborator
Author
There was a problem hiding this comment.
Sure, added, but just wanted to point out that this (URL) one is required because URLs are technically optional in tlog-policy (although, obviously, not for a policy used by a log when signing checkpoints), so we could end up here even though the parser succeeded.
Comment on lines
849
to
851
| if len(witnesses) == 0 { | ||
| return nil, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Should we return an error here if o.witnessPolicy.Quorum is not none but the len(witnesses) is 0?
roger2hk
reviewed
Sep 10, 2026
| 1. Create a new Checkpoint and sign it with the signer provided by [WithCheckpointSigner](https://pkg.go.dev/github.com/transparency-dev/tessera#AppendOptions.WithCheckpointSigner) | ||
| 2. Contact witnesses and collect enough cosignatures to satisfy any witness policy configured by [WithWitnesses](https://pkg.go.dev/github.com/transparency-dev/tessera#AppendOptions.WithWitnesses) | ||
| 2. Contact witnesses and collect enough cosignatures to satisfy any witness policy configured by [WithWitnessPolicy](https://pkg.go.dev/github.com/transparency-dev/tessera#AppendOptions.WithWitnessPolicy) | ||
| 3. If the witness policy is satisfied, make this new Checkpoint public available |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. If the witness policy is satisfied, make this new Checkpoint public available | |
| 3. If the witness policy is satisfied, make this new Checkpoint publicly available |
| return wit | ||
| } | ||
|
|
||
| type keyUrl struct { |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the append lifecycle code to use the
formats/policypackage.Towards #1152