Migrate commands over to TLogPolicy - #1163
Merged
Merged
Conversation
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 8, 2026 15:01
db2262b to
526581d
Compare
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 8, 2026 15:09
526581d to
0a4839a
Compare
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 8, 2026 15:23
0a4839a to
78ef7c7
Compare
AlCutter
marked this pull request as ready for review
September 8, 2026 15:29
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 9, 2026 11:27
78ef7c7 to
0d16e13
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 359b214 | Previous: f1f48c4 | Ratio |
|---|---|---|---|
BenchmarkDedup (github.com/transparency-dev/tessera) |
5204525 ns/op 899884 B/op 18759 allocs/op |
2207022 ns/op 886850 B/op 18650 allocs/op |
2.36 |
BenchmarkDedup (github.com/transparency-dev/tessera) - ns/op |
5204525 ns/op |
2207022 ns/op |
2.36 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) |
11116 ns/op 6528 B/op 1 allocs/op |
1351 ns/op 6528 B/op 1 allocs/op |
8.23 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) - ns/op |
11116 ns/op |
1351 ns/op |
8.23 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) |
147558 ns/op 15355 B/op 180 allocs/op |
56548 ns/op 15353 B/op 180 allocs/op |
2.61 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
147558 ns/op |
56548 ns/op |
2.61 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) |
1597665 ns/op 689109 B/op 3555 allocs/op |
554836 ns/op 689106 B/op 3555 allocs/op |
2.88 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) - ns/op |
1597665 ns/op |
554836 ns/op |
2.88 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) |
141685 ns/op 15439 B/op 180 allocs/op |
56420 ns/op 15411 B/op 180 allocs/op |
2.51 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
141685 ns/op |
56420 ns/op |
2.51 |
This comment was automatically generated by workflow using github-action-benchmark.
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 9, 2026 11:31
0d16e13 to
3c80ce1
Compare
roger2hk
approved these changes
Sep 10, 2026
| if err != nil { | ||
| var wPol policy.TLogPolicy | ||
| if err := wPol.Unmarshal(f); err != nil { | ||
| slog.ErrorContext(ctx, "Failed to create witness group from policy", slog.Any("error", err)) |
Contributor
There was a problem hiding this comment.
Suggested change
| slog.ErrorContext(ctx, "Failed to create witness group from policy", slog.Any("error", err)) | |
| slog.ErrorContext(ctx, "Failed to parse witness policy", slog.Any("error", err)) |
| t.Fatalf("NewWitnessGroupFromPolicy: %v", err) | ||
| var mirrorPolicy policy.TLogPolicy | ||
| if err := mirrorPolicy.Unmarshal(mirrorPolicyRaw); err != nil { | ||
| t.Fatalf("policy.Unmarshal: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Fatalf("policy.Unmarshal: %v", err) | |
| t.Fatalf("mirrorPolicy.Unmarshal: %v", err) |
AlCutter
force-pushed
the
migrate_tlog_policy_4
branch
from
September 10, 2026 10:53
3c80ce1 to
359b214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the binaries under
cmdto use theformats/policypackage.Towards #1152