Deprecate old witness methods - #1165
Merged
Merged
Conversation
AlCutter
force-pushed
the
migrate_tlog_policy_6
branch
from
September 8, 2026 15:01
daf7d6c to
2818910
Compare
AlCutter
force-pushed
the
migrate_tlog_policy_6
branch
from
September 8, 2026 15:09
2818910 to
45db773
Compare
AlCutter
force-pushed
the
migrate_tlog_policy_6
branch
from
September 8, 2026 15:23
45db773 to
8090da7
Compare
AlCutter
marked this pull request as ready for review
September 8, 2026 15:31
AlCutter
force-pushed
the
migrate_tlog_policy_6
branch
from
September 9, 2026 11:31
8090da7 to
f8fe6bc
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: af73263 | Previous: f1f48c4 | Ratio |
|---|---|---|---|
BenchmarkDedup (github.com/transparency-dev/tessera) |
5090917 ns/op 902324 B/op 18784 allocs/op |
2207022 ns/op 886850 B/op 18650 allocs/op |
2.31 |
BenchmarkDedup (github.com/transparency-dev/tessera) - ns/op |
5090917 ns/op |
2207022 ns/op |
2.31 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) |
9754 ns/op 6528 B/op 1 allocs/op |
1351 ns/op 6528 B/op 1 allocs/op |
7.22 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) - ns/op |
9754 ns/op |
1351 ns/op |
7.22 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) |
139986 ns/op 15387 B/op 179 allocs/op |
56548 ns/op 15353 B/op 180 allocs/op |
2.48 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
139986 ns/op |
56548 ns/op |
2.48 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) |
1458195 ns/op 689105 B/op 3555 allocs/op |
554836 ns/op 689106 B/op 3555 allocs/op |
2.63 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) - ns/op |
1458195 ns/op |
554836 ns/op |
2.63 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) |
135636 ns/op 15440 B/op 180 allocs/op |
56420 ns/op 15411 B/op 180 allocs/op |
2.40 |
BenchmarkProofBuilder/ConsistencyProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
135636 ns/op |
56420 ns/op |
2.40 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: f8fe6bc | Previous: f1f48c4 | Ratio |
|---|---|---|---|
BenchmarkDedup (github.com/transparency-dev/tessera) |
3764645 ns/op 900716 B/op 18779 allocs/op |
2207022 ns/op 886850 B/op 18650 allocs/op |
1.71 |
BenchmarkDedup (github.com/transparency-dev/tessera) - ns/op |
3764645 ns/op |
2207022 ns/op |
1.71 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) |
8027 ns/op 6528 B/op 1 allocs/op |
1351 ns/op 6528 B/op 1 allocs/op |
5.94 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) - ns/op |
8027 ns/op |
1351 ns/op |
5.94 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) |
110537 ns/op 15354 B/op 180 allocs/op |
56548 ns/op 15353 B/op 180 allocs/op |
1.95 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
110537 ns/op |
56548 ns/op |
1.95 |
This comment was automatically generated by workflow using github-action-benchmark.
AlCutter
force-pushed
the
migrate_tlog_policy_6
branch
from
September 10, 2026 10:53
f8fe6bc to
af73263
Compare
roger2hk
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks the old witness policy methods deprecated.
Towards #1152