Conversation
roger2hk
approved these changes
Sep 10, 2026
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: e1fbf08 | Previous: 8977b14 | Ratio |
|---|---|---|---|
BenchmarkDedup (github.com/transparency-dev/tessera) |
4174572 ns/op 904284 B/op 18804 allocs/op |
1777569 ns/op 887701 B/op 18666 allocs/op |
2.35 |
BenchmarkDedup (github.com/transparency-dev/tessera) - ns/op |
4174572 ns/op |
1777569 ns/op |
2.35 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) |
8933 ns/op 6528 B/op 1 allocs/op |
1443 ns/op 6528 B/op 1 allocs/op |
6.19 |
BenchmarkLeafBundle_UnmarshalText (github.com/transparency-dev/tessera/api) - ns/op |
8933 ns/op |
1443 ns/op |
6.19 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) |
118157 ns/op 15352 B/op 180 allocs/op |
49401 ns/op 15326 B/op 180 allocs/op |
2.39 |
BenchmarkProofBuilder/InclusionProof/WarmCache (github.com/transparency-dev/tessera/client) - ns/op |
118157 ns/op |
49401 ns/op |
2.39 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) |
1096854 ns/op 689101 B/op 3555 allocs/op |
517302 ns/op 689120 B/op 3555 allocs/op |
2.12 |
BenchmarkProofBuilder/InclusionProof/ColdCache (github.com/transparency-dev/tessera/client) - ns/op |
1096854 ns/op |
517302 ns/op |
2.12 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve logging for witnessing.