Depend on ember-cli-rails 1.x - #47
Draft
tricknotes wants to merge 1 commit into
Draft
tricknotes wants to merge 1 commit into
tricknotes wants to merge 1 commit into
Conversation
The helpers call `EmberCli::App#vite?`, `#startup_tags`, `#javascript_assets` and `#stylesheet_assets`, which no published release exposes, and every release up to 0.14.2 depends on this gem in turn, which Bundler refuses to resolve. `1.0.0` is the release that both adds those readers and drops that dependency, so require it, and stop short of the next major release, which is free to change what the helpers read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#42 declares a dependency on
ember-cli-railswithout naming a version, because the release it needs is not published yet.This names it:
~> 1.0, so only the 1.x series is accepted.No published release works with the helpers of #42, which was checked against every release from
0.13.0on:0.13.0,0.13.1,0.13.2,0.14.0,0.14.1or0.14.2exposevite?,startup_tags,javascript_assetsorstylesheet_assetsonEmberCli::App.Paired with
0.14.2, every example inspec/helpersfails withthe EmberCli::App class does not implement the instance method: vite?ember-cli-rails-assets >= 0.9.0, < 1.0, so Bundler rejects the pair outright:Your bundle requires gems that depend on each other, creating an infinite loop.1.0.0is the release that both adds those readers and drops the dependency back on this gem, so it is the oldest one that can work.The upper bound keeps out the next major release, which is free to change what the helpers read.
What
s.add_dependency "ember-cli-rails", "~> 1.0", replacing the comment that deferred itMerging
Merge this once
ember-cli-rails1.0.0 is published.Until then, CI fails at
bundle install: theGemfileresolvesember-cli-railsfrom the branch of tricknotes/ember-cli-rails#687, whose version is still0.14.2, which~> 1.0does not accept.When 1.0.0 is published, that
Gemfileline comes out andember-cli-railsresolves from RubyGems.