feat(webapp): opt-in worker pool for OTLP ingest transform#4232
Conversation
Move the pure OTLP decode/convert/attribute helpers out of otlpExporter.server.ts into otlpTransform.server.ts, which has no server-singleton imports (env, clickhouse factory, event repository, prisma) so it can run inside a worker thread. The env-derived event-store default is now passed as a parameter. Behavior is identical; typecheck green. Prep for the OTLP ingest worker-pool spike.
…ag-gated) Behind OTEL_TRANSFORM_WORKER_POOL_ENABLED (default off), OTLP protobuf decode + convert + enrich (incl. LLM pricing match/calculateCost) run in a worker_threads pool instead of the request event loop. The main thread stays the single DB reader (broadcasts compiled model rows to workers via ModelPricingRegistry.loadFromModels) and keeps the existing consolidated insertMany path, so ClickHouse insert cadence and part count are unchanged. Adds: otlpTransformWorker (worker entry), otlpWorkerPool (hand-rolled worker_threads pool with per-worker single-flight, pricing broadcast, respawn-on-crash), exporter exportXRaw dispatch methods + flag, route wiring, a bundled build:otlpworker esbuild step, and ModelPricingRegistry.loadFromModels/toSerializable (prisma-optional) + tests. Local e2e on an isolated stack: flag-on sustained ~2.6x throughput (997 -> 2612 spans/s) and kept the main-thread health check responsive (0.5-2.5s vs 4.6-10.4s) at identical load; enriched events with registry-sourced cost verified in ClickHouse via the worker path.
…load The pricing registry now notifies subscribers after every load/reload (interval + pub/sub); the OTLP worker pool subscribes and re-broadcasts the compiled model rows to all workers, so their in-memory pricing stays fresh instead of being a static snapshot from pool creation. Respawned workers also inherit the latest snapshot via workerData. Verified on the isolated stack: broadcast fires on init then every reload interval to all workers; registry-sourced cost enrichment kept landing in ClickHouse across multiple reload cycles under load (no break).
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds shared OTLP transformation utilities for logs, traces, and metrics, plus a worker-thread pool that processes raw protobuf payloads and receives pricing updates. The exporter now exposes raw-processing methods and conditionally uses them from OTLP routes when enabled. Pricing registries can load serialized models without database access and notify subscribers after reloads. The change also adds ingestion metrics, worker-pool metric tests, build configuration, environment settings, and a changelog entry. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Address review feedback on the opt-in worker pool: - Validate the pool config through env.server and clamp the worker count to at least 1, so a zero or non-numeric OTEL_TRANSFORM_WORKER_POOL_SIZE can no longer leave an empty pool that hangs every request. - Add a per-task timeout (reject and reap a stuck worker) and a bounded queue (shed when full), so a wedged worker or overload can't hang requests forever or grow memory without limit. - Respawn crashed workers with exponential backoff instead of a tight loop. - Guard the immediate pricing-reload listener replay so a throwing listener can't escape subscription setup.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…messages A crashing worker fires both error and exit, so reap() ran twice (double respawn and double backoff increment). reap() now returns early once the worker has been removed. The message handler also ignores late messages from an already-reaped worker, which otherwise pushed a dead worker back into the idle set.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
A worker that exits cleanly (code 0) while holding a task previously left the request hanging until the task timeout and the pool one worker short. Reap on any exit; the double-reap guard makes this a no-op when error already reaped it.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Instruments the OTLP ingest path, the transform worker pool, and the shared flush scheduler with OpenTelemetry metrics under a single ingest.* prefix: request and byte throughput with per-signal produced counts, worker task vs compute durations plus queue depth and worker health, and flush batch size, duration, queue depth and dropped-batch counters. Reuses the existing MeterProvider and is gated by the existing INTERNAL_OTEL_METRIC_EXPORTER_ENABLED, so every instrument is a no-op when metrics are disabled. Recording happens in bulk once per request or flush (never per span) with pull-based gauges, so it stays off the hot path.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts (1)
138-181: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winInjected
meterisn't propagated to the internal flush schedulers.
meteris only used to build_droppedBatchesCounter; none of the threeDynamicFlushSchedulerconfigs receive it, so they always fall back to the globalgetMeter("ingest-flush")provider regardless of what's injected here. This breaks the "inject a meter for self-observability" contract documented on the config field and makes it impossible to fully isolate this repository's flush metrics in tests.🔧 Proposed fix
this._flushScheduler = new DynamicFlushScheduler({ name: `task_events_${this._version}`, + meter, batchSize: config.batchSize ?? 1000, ... }); this._llmMetricsFlushScheduler = new DynamicFlushScheduler({ name: "llm_metrics", + meter, batchSize: config.llmMetricsBatchSize ?? 5000, ... }); this._otlpMetricsFlushScheduler = new DynamicFlushScheduler({ name: "otlp_metrics", + meter, batchSize: config.otlpMetricsBatchSize ?? 10000, ... });
🧹 Nitpick comments (3)
apps/webapp/app/v3/otlpWorkerPool.server.ts (1)
216-226: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low valuePush worker back to idle when task is missing in
drain().If
this.tasks.get(id)returnsundefined, the worker was already popped fromthis.idlebut thecontinueskips it — the worker is leaked from the idle pool until the nextspawn()orrelease(). This path is currently unreachable (all task-deletion sites also remove the id from the queue), but the defensive guard should not introduce a resource leak if it ever triggers.♻️ Proposed fix
private drain() { while (this.queue.length > 0 && this.idle.length > 0) { const worker = this.idle.pop()!; const id = this.queue.shift()!; const task = this.tasks.get(id); - if (!task) continue; + if (!task) { + this.idle.push(worker); + continue; + } task.worker = worker; this.busyByWorker.set(worker, id); worker.postMessage(task.message, task.transfer); } }apps/webapp/test/otlpWorkerPoolMetrics.test.ts (1)
13-75: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider adding tests for timeout, crash, queue-full rejection, and respawns counter.
The current tests cover
okanderroroutcomes but nottimeout,crash,rejected(queue full), or theingest.worker_pool.respawnscounter. These are the more complex failure paths in the worker pool. A test for the respawns counter (e.g., using a worker that exits immediately) would be particularly valuable for validating worker health monitoring.apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts (1)
372-374: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDropped-batch counter labeling:
tablevsschedulernaming inconsistency.
DynamicFlushScheduler's metrics key onscheduler, while this counter keys ontable. Both are bounded/low-cardinality, but the differing label name makes it harder to correlateingest.flush.batches_droppedwith the corresponding scheduler's otheringest.flush.*series in dashboards/queries.Also applies to: 403-406
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: df57e2ac-b833-41d1-9568-ca253110e1a5
📒 Files selected for processing (11)
apps/webapp/app/v3/dynamicFlushScheduler.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/otlpExporter.server.tsapps/webapp/app/v3/otlpTransformWorker.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/test/fixtures/otlpEchoWorker.cjsapps/webapp/test/fixtures/otlpErrorWorker.cjsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/otlpWorkerPoolMetrics.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/webapp/app/v3/otlpTransformWorker.ts
- apps/webapp/app/v3/otlpExporter.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (28)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: code-quality / code-quality
- GitHub Check: audit
- GitHub Check: audit
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or the deprecatedclient.defineJob.
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Place test files next to their source files, e.g.
MyService.ts->MyService.test.ts.
Files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
🧠 Learnings (20)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/test/otlpMetrics.helpers.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/otlpWorkerPoolMetrics.test.tsapps/webapp/test/dynamicFlushSchedulerMetrics.test.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/eventRepository/eventRepository.server.tsapps/webapp/app/v3/otlpWorkerPool.server.tsapps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.tsapps/webapp/app/v3/dynamicFlushScheduler.server.ts
🔇 Additional comments (12)
apps/webapp/app/v3/otlpWorkerPool.server.ts (3)
53-117: OTEL metrics setup looks solid.All metric attributes are low-cardinality:
kind(3 values),outcome(5 values),reason(3 values),state(2 values). Pre-allocated_kindAttrsobjects avoid per-task allocations. Pull-based gauges have zero hot-path cost. As per coding guidelines, OTEL metric attributes must use only enums, booleans, bounded error codes, or bounded shard IDs — all attributes here comply.Source: Coding guidelines
118-244: Worker lifecycle, reap, and timeout handling are well-implemented.The idempotency guard in
reap()(line 176), exponential backoff inscheduleRespawn()withconsecutiveFailuresreset on success, per-task timeout with worker reaping, and late-message guard (line 138) all address previously identified concerns. The implementation is clean.
245-305:runTransform,broadcastPricing, andshutdownare correct.Bounded queue rejection, zero-copy transfer, pricing broadcast to all workers with cache update, and shutdown that prevents respawns by splicing workers before termination — all look good.
apps/webapp/test/fixtures/otlpEchoWorker.cjs (1)
1-7: LGTM!apps/webapp/test/fixtures/otlpErrorWorker.cjs (1)
1-7: LGTM!apps/webapp/test/otlpMetrics.helpers.ts (1)
1-67: LGTM!apps/webapp/test/otlpWorkerPoolMetrics.test.ts (2)
22-53: Good coverage of success-path metrics.The test correctly validates ok-outcome counts by kind, task/compute duration histogram counts, and gauge values for alive workers and queue depth. The
vi.waitForpolling withcreateInMemoryMetricsis a clean approach.
55-74: Error-outcome test is well-structured.Using a dedicated error worker fixture to verify the
erroroutcome counter is a clean approach.apps/webapp/app/v3/dynamicFlushScheduler.server.ts (1)
3-3: LGTM!Also applies to: 20-25, 63-77, 103-151, 163-163, 285-289, 330-330
apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts (1)
11-12: LGTM!apps/webapp/app/v3/eventRepository/eventRepository.server.ts (1)
103-118: LGTM!apps/webapp/test/dynamicFlushSchedulerMetrics.test.ts (1)
1-133: LGTM!
Register SIGTERM/SIGINT handlers for the OTLP transform worker pool so that on shutdown it stops accepting new work, lets in-flight transforms finish (bounded), and terminates its workers, instead of leaving them to be force-killed. This avoids respawn churn and error-log noise during a graceful shutdown; the main thread stays the only DB writer, so inserts are unaffected.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…gleton Use the shared singleton() helper (stored on globalThis) for the OTLP transform worker pool, like otlpExporter and llmPricingRegistry, so a single pool and its worker threads survive Remix hot-reloads in dev instead of orphaning workers on every reload. Production is unaffected. Also drops the unused broadcastPricingToPool helper.
2 participants
Summary
Under high OTLP ingest volume, the whole decode, transform, and enrich pipeline runs on the request event loop, so a single CPU core becomes the ceiling while the rest sit idle. This adds an opt-in worker pool that moves decode, transform, and LLM-cost enrichment onto worker threads, keeping the main thread free for I/O. It is off by default (
OTEL_TRANSFORM_WORKER_POOL_ENABLED), so behavior is unchanged unless enabled.Design
Workers do decode, filter, convert, and enrich (including LLM pricing match). The main thread stays the single database reader: it loads the pricing registry and broadcasts the compiled model rows to the workers (re-broadcasting on every reload), so workers never touch the database. The pure transform is extracted into a dependency-light module (no Prisma/Redis/ClickHouse imports) so it can run inside a worker.
Importantly, the main thread keeps the existing single consolidated insert path, so ClickHouse insert batching and part count are unchanged. The parallelism buys CPU headroom, not more insert streams (which would add merge pressure).
The worker is bundled as a standalone file at build time and ships in the existing image with no Dockerfile change. In local load testing the pool sustained roughly 2.6x the throughput of the single-thread path and kept the main thread responsive under load.