Skip to content

test(core): fix flakey run-stream test depending on ordering #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carderne merged 1 commit into from
Jul 14, 2026
Merged

test(core): fix flakey run-stream test depending on ordering #4256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 12 additions & 29 deletions packages/core/test/runStream.test.ts
View file
Open in desktop
Comment thread
carderne marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -354,36 +354,19 @@ describe("RunSubscription", () => {
// Verify we only created one stream
expect(streamCreationCount).toBe(1);

// Verify we got all the expected events
// Run-shape and stream events are produced independently, so their relative
// ordering is not guaranteed. Preserve ordering within each source instead.
expect(results).toHaveLength(4);
expect(results[0]).toMatchObject({
type: "run",
run: {
id: "run_123",
taskIdentifier: "openai-streaming",
status: "EXECUTING",
durationMs: 100,
},
});
expect(results[1]).toMatchObject({
type: "openai",
chunk: { id: "chunk1", content: "Hello" },
run: { id: "run_123", durationMs: 100 },
});
expect(results[2]).toMatchObject({
type: "openai",
chunk: { id: "chunk2", content: "World" },
run: { id: "run_123", durationMs: 100 },
});
expect(results[3]).toMatchObject({
type: "run",
run: {
id: "run_123",
taskIdentifier: "openai-streaming",
status: "EXECUTING",
durationMs: 200,
},
});

const runEvents = results.filter((event) => event.type === "run");
expect(runEvents.map((event) => event.run.durationMs)).toEqual([100, 200]);

const streamEvents = results.filter((event) => event.type === "openai");
expect(streamEvents.map((event) => event.chunk)).toEqual([
{ id: "chunk1", content: "Hello" },
{ id: "chunk2", content: "World" },
]);
expect(streamEvents.map((event) => event.run.durationMs)).toEqual([100, 100]);
});

it("should handle multiple streams simultaneously", async () => {
Expand Down
Loading