Repository navigation
Assert that reporting an item puts it back in review - #308
Merged
Merged
Conversation
No behaviour change. sendForReview() has always set NeedsReview and cleared reviewed_at; nothing tested that it does. The stamp is the half worth pinning: an item reviewed once carries one, and a sweep that skips already-reviewed items would quietly pass over the thing somebody just reported. The status alone would not save it. Seven tests covering the status, the stamp, the stored reason and note, every reason the apps offer, an unknown reason, authentication, and reporting an item that is already in review -- both complaints are kept, since an item wrong in two ways is wrong twice. Both halves confirmed to fail when removed. Written because the iOS app is gaining "Mark for review" on films, shows and episodes, and that guarantee should not rest on reading the model.
Owner
Author
|
Reviewed on a5 — clean. 7 tests pass. Test-only, no behaviour change — pins that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour change — tests for a guarantee the iOS app is about to depend on.
sendForReview()has always setNeedsReviewand clearedreviewed_at. Nothing tested that it does.The stamp is the half worth pinning. An item reviewed once carries a
reviewed_at, and a sweep that skips already-reviewed items would quietly pass over the very thing somebody just reported. The status alone would not save it — which is the kind of thing that works until the day a sweep changes.Seven tests: the status is set, the stamp is cleared, the chosen reason and note are stored, every reason the apps offer is accepted, an unknown one is refused, authentication is required, and an item already in review can be reported again (both complaints kept — an item wrong in two ways is wrong twice).
Both halves confirmed to fail when removed. 366 pass across the review, report, media and API suites.
Paired with SoundChexiOS #93, which adds "Mark for review" to films, shows and episodes — the picker existed but was reachable only from music.