Conversation
Dockerfile.sdk now defaults to the cuda-dl-base inference-runtime image, so this override both contradicts that default and pins the image being retired. It is removed rather than repointed: the replacement tag couples the container train to a CUDA version (26.09-cuda13.4), which cannot be derived from UPSTREAM_CONTAINER_VERSION alone. Letting Dockerfile.sdk's own default apply keeps the image versioned in one place instead of drifting in a QA script.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Dockerfile.sdk'sBASE_IMAGEwithtritonserver:${UPSTREAM_CONTAINER_VERSION}-py3-min, pinning the image beingretired and contradicting that Dockerfile's own default.
which
UPSTREAM_CONTAINER_VERSIONcannot express.Where should the reviewer start?
inferentia/qa/setup_test_enviroment_and_test.sh— the removed--build-argline in the SDK
docker build.Related PRs:
Related Issues: