Skip to content

fix: Drop the py3-min BASE_IMAGE override from the inferentia SDK build - #458

Open
mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1930/inference-image
Open

mc-nv wants to merge 1 commit into
mainfrom
mchornyi/TRI-1930/inference-image

Conversation

@mc-nv

@mc-nv mc-nv commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What does the PR do?

  • The inferentia QA script overrode Dockerfile.sdk's BASE_IMAGE with
    tritonserver:${UPSTREAM_CONTAINER_VERSION}-py3-min, pinning the image being
    retired and contradicting that Dockerfile's own default.
  • Removed rather than repointed: the replacement couples train to CUDA version,
    which UPSTREAM_CONTAINER_VERSION cannot express.

Where should the reviewer start?

  • inferentia/qa/setup_test_enviroment_and_test.sh — the removed --build-arg
    line in the SDK docker build.

Related PRs:

Related Issues:

  • Resolves: TRI-1930

Dockerfile.sdk now defaults to the cuda-dl-base inference-runtime image, so
this override both contradicts that default and pins the image being retired.

It is removed rather than repointed: the replacement tag couples the container
train to a CUDA version (26.09-cuda13.4), which cannot be derived from
UPSTREAM_CONTAINER_VERSION alone. Letting Dockerfile.sdk's own default apply
keeps the image versioned in one place instead of drifting in a QA script.
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Removes a Docker build argument from the SDK test setup.

The PR appears safe to merge based on the reviewed change.

Summary

The PR removes the Inferentia QA script’s explicit SDK BASE_IMAGE override, leaving image selection to the checked-out server repository’s Dockerfile.sdk.

  • The locally built server remains the QA container’s runtime base.
  • The SDK image supplies client artifacts to that QA container.

Reviews (1) · Last reviewed commit: "fix: Drop the py3-min BASE_IMAGE overrid..."

@mc-nv
mc-nv requested review from Vinya567, nv-rinig and whoisj October 2, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix (fix: PRs)

Development

Successfully merging this pull request may close these issues.

1 participant